I bought 2 holsters, one for a Makarov and one for a PPKS. My Makarov had been updated with target sights, making it difficult to holster the pistol because the rear sight was slightly higher and wider than the original, and caught the top of the holster. I could have trimmed the holster leather back about 1/2", away from the sight, but decided to use a leather conditioner and softened the area around the sight and stretched the leather enough to make it fit properly. The Makarov fills the holster very snugly. If you want to use the spare mag holder, it's an extremely tight fit also (the mag spring loading tab bites into the pouch leather).
The PPKS is a smaller pistol all around and fit easily and deeply into the holster. The PPKS mag also fits tightly into the pouch, but is snag free.
If you are looking for a period correct holster, this is a good one. Mine looked to be brand new, never used, and well worth the price. However, I would look for a modern style holster if I was shopping for a concealed carry option.